search

twinnydotdev / twinny

The most no-nonsense, locally or API-hosted AI code completion plugin for Visual Studio Code - like GitHub Copilot but completely free and 100% private.
https://twinny.dev
MIT License
2.3k stars 126 forks source link

Keyboard Shortcuts - Add opt-in option #220

Open superlinkx opened 2 months ago

superlinkx commented 2 months ago

Describe the bug Having shortcuts that use ctrl+shift+t as a chord cause the commonly bound ctrl+shift+t shortcut to be overwritten as the start of a chord, breaking reopening a closed tab by default.

To Reproduce Steps to reproduce the behavior:

  1. Use default keybinds
  2. Close an open tab
  3. Press ctrl+shift+t
  4. Note that at the bottom of the editor, VS Code is waiting for the rest of a chord
  5. Closed tab won't reopen

Expected behavior Existing keybind should be respected, and by default that means it should reopen a closed editor tab

Desktop (please complete the following information):

Additional context It may be wise to not create keyboard shortcuts by default and let users opt-in

rjmacarthy commented 2 months ago

Hey thanks for the report, sorry about that! I just updated the keyboard shortcuts to not override any defaults. Opt-in would require more work and I'm too lazy at the moment to work on it :).

Many thanks,

superlinkx commented 2 months ago

Appreciate all the work you do, I've been loving this extension otherwise!