search

twinslash / redmine_omniauth_google

This plugin is used to authenticate in redmine through Google.
http://www.redmine.org/plugins/redmine_omniauth_google
95 stars 103 forks source link

Plugin modification for redmine 3.4.2 on ruby 2.4 #40

Open wlk-cz opened 7 years ago

wlk-cz commented 7 years ago

I am not ruby specialist, but I spend last two days learning this language to get this plugin work. I have to change array association on many places from @settings[:client_id] to @settings['client_id'] for all plugin parameters. Can someone explain me, why? Without this modification the plugin didn't store settings and didn't show google login button.

etonline commented 7 years ago

Thank you for digging this, it works for my newly install Redmine :)

However, the Google Login button doesn't show...

babykart commented 6 years ago

@wlk-cz thank you for your patch that fixed on:

Environment:
  Redmine version                3.4.3.stable
  Ruby version                   2.2.8-p477 (2017-09-14) [x86_64-linux]
  Rails version                  4.2.8
  Environment                    production
  Database adapter               Mysql2
SCM:
  Git                            2.15.1
  Filesystem                     
Redmine plugins:
  redmine_omniauth_google        0.0.1
guss77 commented 6 years ago

Also works for me :+1: .

@twinslash, please merge? :pray:

ahosch commented 6 years ago

This worked for me as well using the pull request associated with #42 Replace not working with symbols to strings