search

twinssbc / AngularJS-ResponsiveCalendar

A pure AngularJS responsive calendar directive
http://twinssbc.github.io/AngularJS-ResponsiveCalendar/demo/
MIT License
112 stars 77 forks source link

CalendarController should be named before used #33

Closed n9986 closed 8 years ago

n9986 commented 8 years ago

I believe it will be good to namespace CalendarController. It caused a conflict with another controller in my app named as CalendarController. While I should have namespaced it as well, I guess it would be good to do this in this code as a best practice.

Thank you for this great library!

twinssbc commented 8 years ago

@n9986 I have updated the controller name, thanks for your suggestion.