Not compatible with ionic v 4

twinssbc / Ionic2-Calendar

A calendar component based on Ionic framework

https://ionic-calendar-demo.stackblitz.io

MIT License

389 stars 199 forks source link

Not compatible with ionic v 4 #372

Closed hugoblanc closed 5 years ago

hugoblanc commented 6 years ago

Due to the new version of RxJS, the way to import Observable is not correct anymore:

[ng] node_modules/ionic2-calendar/calendar.service.d.ts(1,10): error TS2305: Module '"C:/programming/studay/node_modules/rxjs/Observable"' has no exported member 'Observable'.

import { Observable } from "rxjs/Observable"; should be import { Observable } from "rxjs";

I don't know for the rest of the plugin

marticrespi commented 6 years ago

@hugoblanc he shoud upgrade this part, but you can pass this error installing rxjs-compat

npm i rxjs-compat --save

This is not a problem with ionic v4, the real problem with ionic 4 is that this library is based on ionic 3 and you when try to serve or build the project shows these errors:

[ng] ERROR in node_modules/ionic2-calendar/dayview.d.ts(1,24): error TS2307: Cannot find module 'ionic-angular'. [ng] node_modules/ionic2-calendar/monthview.d.ts(2,24): error TS2307: Cannot find module 'ionic-angular'. [ng] node_modules/ionic2-calendar/weekview.d.ts(1,24): error TS2307: Cannot find module 'ionic-angular'.

This is the main reason that it's not compatible with ionic v4.

@twinssbc , is planned to upgrade from ionic-angular(3) to @ionic/angular(4)?