search

twintechs / TwinTechsFormsLib

Apache License 2.0
193 stars 73 forks source link

PageViewContainer and Back button #3

Open Axel3232 opened 9 years ago

Axel3232 commented 9 years ago

Hi George,

Once again, thanck for this great work, I have been playing with your PageViewContainer which work great excpet the back button of the NavigationPage, as you spotted in this bug

Did you find any work around ? May be with your GestureRecognizer if the bug is caused by the native one as you commented ?

Axel

georgejecook commented 9 years ago

Hi Axel,

Glad you see value in this component. I think that this is the key to our whole library. I've just made an app with the same navigation UX as skype for iphone, all in native Xamarin!

Saying that yes, this navigation thing is an issue. There's more workaround needed here unfortunately. It seems that the navigation controller get's very confused and that Xamarin's INavigation interface breaks down.

I think going forward, I'll have to add extension methods to Page to allow it to get a working INAvigaiton reference, which actually correctly pushes page.

As for your issue with the back button : I've not had a chance to investigate it. I shan't be improving this till next week. I do however, have some commits coming which fix some bugs. But I'm not hopeful for a positive result here. I'm using custom navigation stacks in our app, so this isn't an issue. It might be that anyone wanting to embed an out the box NavigationPage get's no joy.

In any cases, comment on the bug - and let them know that it's a use case you need resolved too.

Axel3232 commented 9 years ago

Thank for the quick anwser George, I agree this component is also the most valuable from my standpoint.

I’ll wait that the XF team publish their big bug correction rush they seem to be in right now.

That said they may provide a similar component out of the box in the new release since your feature request https://bugzilla.xamarin.com/show_bug.cgi?id=28526 is now tagged as “RESOLVED FEATURE” in Bugzilla don’t you think ?

Axel3232 commented 9 years ago

Hi George,

Just to let you know that the PageContainer, works fine with a MasterDeatilPage as content. Except if the detail page of the MD is a NavigationPage, the back button is still inactive.

image

This is so frustrating, hope XF's guys fix that quicly, because I really need that. Anyway thank for this great work.

georgejecook commented 9 years ago

Well, that's good to know. I saw Xamarin said they've implemented this; but I've no idea what it looks like or when they'll release it, so I'm going to keep developing this.

Navigation is broken when embedded. Again, no word from Xamarin. I've not yet tried rolling my own navigation page, which is the likely next step, at least a crude one to see if it's a Xamarin problem or not. I don't much care for Xamarin's INavigationService, preferring instead a viewmodel based service I use, and in any case, anyone using this control in their app, with a navigation page is likely writing such a custom UI as to want a custom navigation service anyhow.

So, what I'm getting at, is that I might end up solving the navigationpage issue; but it likely will be incompatible with the INavigationService.

georgejecook commented 9 years ago

Axel,

thought you might like to know that I've got it working on android: Image of it working on android