twintechs / TwinTechsFormsLib

Apache License 2.0
193 stars 73 forks source link

Fix for incorrect listview behaviour on Android #6

Closed maartenvana closed 9 years ago

maartenvana commented 9 years ago

This change creates new cells instead of reusing the given Cell objects from the listview creating unstable behaviour (item selected/tapped not returning the expected item).

The caching of original binding context is now irrelevant, this can be removed from the cell cache.

This bug can be reproduced with the FastSimpleCellLots.xaml page by scrolling about halfway down and back up, the first item in the list returns a different object than expected.

This fix is only for Android but can be applied to iOS aswell

georgejecook commented 9 years ago

great spot. thank you. I've applied it also to iOS.