search

twisted-infra / braid

Automation scripts for twistedmatrix.com
Other
6 stars 12 forks source link

Some simple Python 3 fixes #240

Closed rodrigc closed 7 years ago

rodrigc commented 7 years ago

@adiroiban Can you review this?

adiroiban commented 7 years ago

looks good. thanks!

changes-approved

rodrigc commented 7 years ago

@hawkowl @adiroiban @glyph Can someone merge this? I can't do it on this repository. Thanks.

adiroiban commented 7 years ago

hi. sorry for the delay. I made you admin on this repo.

I have no idea what are the rules for having new people in Twisted-Infra.

Please let me know if you can merge it now.

Thanks!

rodrigc commented 7 years ago

Thanks @adiroiban ! I don't know what the procedures are for merging to braid either. I'm going to assume that as long as the change is reviewed by a braid member, and it isn't too bad, it should be OK.

Thanks!

adiroiban commented 7 years ago

The past merged were "dirty". Not many PR and not many reviews.

As long as there is a PR and a review , it is well above the existing practices.

See if you can use the GitHub merge button, and feel free to merge.

Thanks!