search

twisted / ampoule

Process pool for Twisted, using AMP
Other
12 stars 19 forks source link

modernize logging #22

Closed glyph closed 5 years ago

glyph commented 6 years ago

Ampoule presently makes heavy use of (old, one-day-hopefully deprecated) log.msg, and worse yet, frequently does string interpolation on log messages (see here for example).

Let's clean this up to use twisted.logger.

ldanielburr commented 5 years ago

Only a few files involved, I'll take a crack at this. I think .msg should generally be treated as .info in twisted.logger parlance. For logging occurring in error-handling code, I think .error is ok, although an operator might wish to have the option to change .error to .failure if they want to see tracebacks.

ldanielburr commented 5 years ago

I put together PR #29 for this. It is a pretty short read when/if someone has a moment.

ldanielburr commented 5 years ago

I should also note that the labels available here in the ampoule repository differ from the twisted repository. Most notably, there is no "review required" label here in ampoule.

glyph commented 5 years ago

Fixed in #29 .