Don't return an already-dead child to the ready pool

[hyperair]

A single-worker pool that times out will fail all subsequent tasks currently in queue with errors.ProcessTerminated.

The sequence of events is this:

• _returned is called with errors.ProcessTerminated, but die=False
• The dead child is returned to self.ready
• self._catchUp schedules the next task on the dead child
• Repeat

To avoid that, we should avoid returning the already-dead worker to the pool, and just call stopAWorker(child) instead.

[glyph]

Thanks @hyperair !

[glyph]

(Please feel free to @-mention me when you update this, since my github notifications are beyond redemption, and if a thing has been updated and is ready to merge I'd love to hear about it…)

[glyph]

@hyperair Just checking in - do you think you'll be able to address any of the review feedback here?

[hyperair]

@glyph Sorry for the late reply -- I hadn't noticed your comments until my colleague pointed them out to me. I'll work on applying your suggestions.

One thing though -- regarding the HangForever.responder decorator, I knew about the syntax, but specifically didn't use it to be consistent with the rest of the file. Do you wish for me to use the decorator syntax only in this instance, or to convert the entire file to the decorator syntax?

[glyph]

Do you wish for me to use the decorator syntax only in this instance, or to convert the entire file to the decorator syntax?

Go ahead and use the new syntax in your changes; let's have a separate change which updates the other syntaxes. If you wanted to do that one too that would be great, but is not necessary to merge this :)

[glyph]

Thanks for your response!

[hyperair]

@glyph Well, I think I got everything. Could you have another look please?

[hyperair]

No problem, thanks for merging it.

[sfdye]

@glyph Could a new version be released to include this change? Thanks!

[glyph]

@sfdye it’s on my list, but the list is long:) would you like to become an ampoule release manager?