search

twisted / incremental

A library for versioning your Python projects.
Other
138 stars 22 forks source link

Enable codecov.io PR comments. #74

Closed adiroiban closed 3 years ago

adiroiban commented 3 years ago

This is a quick PR to enable codecov.io PR comments.

This PR will not have a comment, and it is configured to only send if the coverage was changed.

The commit status for coverage was not enable...as due to an error, it was configured to wait for 15 test job results ... we we don't have that many.

It also adds a separate check for the tests code to make sure it always has 100% and we don't accidentally always skip a code.

I have enabled py3.9 tests as required for a merge. I have also enabled "Require conversation resolution before merging" to make sure comments are not accidentally ignored.

adiroiban commented 3 years ago

I tried using tox-gh-action ...but I didn't like it. if we go with tox-gh-action, when we want to update the matrix, we would need to update 2 files. githuh workflow .yaml to update the matrix and tox.ini

adiroiban commented 3 years ago

This is ready for review... there are still some transient partial reports sent by codecov... but I don't know how to fix them

but incremental tests are fast, so it shouldn't be a big issue

graingert commented 3 years ago

I tried using tox-gh-action ...but I didn't like it. if we go with tox-gh-action, when we want to update the matrix, we would need to update 2 files. githuh workflow .yaml to update the matrix and tox.ini

I meant just for the folding feature not the environment detection

codecov[bot] commented 3 years ago

Codecov Report

Merging #74 (1bdc8ec) into trunk (48d7b97) will increase coverage by 0.00%. The diff coverage is n/a.

@@           Coverage Diff           @@
##            trunk      #74   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files           5        6    +1     
  Lines         761      768    +7     
  Branches       65       65           
=======================================
+ Hits          756      763    +7     
  Misses          2        2           
  Partials        3        3
Impacted Files Coverage Δ
tests/test_exampleproj.py 100.00% <0.00%> (ø)
adiroiban commented 3 years ago

I meant just for the folding feature not the environment detection

@graingert it might be that I don't understand how the tox gha tool works.

Free free to push a change that uses it.

I tried the read the docs, but I didn't find it useful.

adiroiban commented 3 years ago

Thanks @graingert for the review and help. Regarding tox gh-actions helper. I am not rejecting that change... is just that I don't know how to use that tools.