twisted / klein

werkzeug + twisted.web
Other
836 stars 121 forks source link

(maybe) put hypothesis back #588

Open glyph opened 1 year ago

glyph commented 1 year ago

586 removed hypothesis, but left the door open for re-integrating it if we can address a couple of issues:

exarkun commented 1 year ago

fix the bug in Hyperlink's strategies that generates bogus URLs https://github.com/python-hyper/hyperlink/issues/153

I fixed this almost a year ago with absolutely no response from the maintainers. Any ideas how to actually get any changes in to Hyperlink?

Zac-HD commented 1 year ago

👋 I can't do much about the hyperlink issue, but happy to help you find a hypothesis workflow you like. It sounds like this suggestion from @nelhage might work well:

Alternatively, using e.g. max_examples=20, derandomize=True in your CI settings might be sufficient to meet your goals.

glyph commented 1 year ago

fix the bug in Hyperlink's strategies that generates bogus URLs python-hyper/hyperlink#153

I fixed this almost a year ago with absolutely no response from the maintainers. Any ideas how to actually get any changes in to Hyperlink?

Hmm. Apparently I'm a maintainer so maybe I can do something about that. Are you referring to this? https://github.com/python-hyper/hyperlink/pull/178 Was it ever passing CI?

exarkun commented 1 year ago

fix the bug in Hyperlink's strategies that generates bogus URLs python-hyper/hyperlink#153

I fixed this almost a year ago with absolutely no response from the maintainers. Any ideas how to actually get any changes in to Hyperlink?

Hmm. Apparently I'm a maintainer so maybe I can do something about that. Are you referring to this? python-hyper/hyperlink#178 Was it ever passing CI?

That's the one, yes. I don't remember any of the details.