Codecov Report

Merging #202 into master will increase coverage by 0.00%. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #202   +/-   ##
=======================================
  Coverage   93.84%   93.85%           
=======================================
  Files          74       73    -1     
  Lines       10285    10278    -7     
  Branches     1022     1022           
=======================================
- Hits         9652     9646    -6     
  Misses        514      514           
+ Partials      119      118    -1

Impacted Files	Coverage Δ
ldaptor/protocols/ldap/ldapclient.py	`91.72% <ø> (-0.06%)`	:arrow_down:
ldaptor/protocols/ldap/ldaperrors.py	`100.00% <ø> (ø)`
ldaptor/protocols/ldap/ldapserver.py	`81.90% <ø> (-0.06%)`	:arrow_down:
ldaptor/protocols/pureber.py	`90.82% <ø> (-0.04%)`	:arrow_down:
ldaptor/protocols/pureldap.py	`94.56% <ø> (-0.01%)`	:arrow_down:
ldaptor/test/test_pureber.py	`100.00% <ø> (ø)`
ldaptor/test/test_pureldap.py	`100.00% <ø> (ø)`
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 22d6963...03015e2. Read the comment docs.

adiroiban commented 3 years ago

@graingert you are the hero of the day :) Nice work. I have accidentally left just a review comment instead of approving it.

graingert commented 3 years ago

@adiroiban you did indeed approve, I just dismissed your review - because I made changes

twisted / ldaptor

remove remnants of LGPL headers #202

Contributor Checklist:

Codecov Report