twisted / ldaptor

LDAP server, client and utilities, using Twisted Python
MIT License
158 stars 54 forks source link

remove old ImportError/AttributeError based compat code #203

Closed graingert closed 3 years ago

graingert commented 3 years ago

Fixes https://github.com/twisted/ldaptor/issues/4

we now depend on Twisted[tls]>=15.5.0 for py3.5 support and so don't need the compat shims

Contributor Checklist:

codecov[bot] commented 3 years ago

Codecov Report

Merging #203 into master will increase coverage by 0.07%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
+ Coverage   93.77%   93.85%   +0.07%     
==========================================
  Files          74       74              
  Lines       10302    10285      -17     
  Branches     1022     1022              
==========================================
- Hits         9661     9653       -8     
+ Misses        523      514       -9     
  Partials      118      118              
Impacted Files Coverage Δ
ldaptor/entry.py 95.02% <ø> (+0.90%) :arrow_up:
ldaptor/protocols/ldap/ldapconnector.py 43.52% <ø> (-0.92%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 66f0b04...e2d62d7. Read the comment docs.