twisted / ldaptor

LDAP server, client and utilities, using Twisted Python
MIT License
160 stars 53 forks source link

Replace use of deprecated decode encode string #211

Closed graingert closed 4 years ago

graingert commented 4 years ago

Contributor Checklist:

graingert commented 4 years ago

these are actually removed on py3.9 so need to go! Probably worth doing a release after this one

codecov[bot] commented 4 years ago

Codecov Report

Merging #211 into master will decrease coverage by 0.00%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
- Coverage   83.30%   83.30%   -0.01%     
==========================================
  Files          87       87              
  Lines       11570    11569       -1     
  Branches     1184     1184              
==========================================
- Hits         9638     9637       -1     
  Misses       1815     1815              
  Partials      117      117              
Impacted Files Coverage Δ
ldaptor/entry.py 95.02% <ø> (ø)
ldaptor/protocols/ldap/ldif.py 100.00% <ø> (ø)
ldaptor/protocols/ldap/ldifprotocol.py 98.95% <ø> (ø)
ldaptor/test/test_ldif.py 100.00% <ø> (ø)
ldaptor/test/test_server.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c687081...d80addb. Read the comment docs.

graingert commented 4 years ago

merging this now, will decide on the changelog at the next release - eg if twisted does ship a 3.9 supporting build before we do

adiroiban commented 4 years ago

I guess that ldaptor can have a release with support 3.9 before Twisted.

As long as the tests are green on Python 3.9 it means that ldaptor is ready for 3.9. I don't see why ldaptor should be blocked waiting for a Twisted release.

So if #210 is green I think it can be merged and if someone wants to run ldaptor on 3.9 we can also have a new release.