twisted / ldaptor

LDAP server, client and utilities, using Twisted Python
MIT License
160 stars 53 forks source link

check if key in self._object_class_keys #220

Open scottcarr opened 3 years ago

scottcarr commented 3 years ago

It's possible for key to be either "objectClass" or b"objectClass". Other places use this self._object_class_keys to handle this scenario.

codecov[bot] commented 3 years ago

Codecov Report

Merging #220 (b9cdd0a) into master (df81510) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head b9cdd0a differs from pull request most recent head 8e5a9e8. Consider uploading reports for the commit 8e5a9e8 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #220   +/-   ##
=======================================
  Coverage   83.28%   83.28%           
=======================================
  Files          87       87           
  Lines       11567    11567           
  Branches     1184     1184           
=======================================
  Hits         9634     9634           
  Misses       1815     1815           
  Partials      118      118           
Impacted Files Coverage Δ
ldaptor/protocols/ldap/ldapsyntax.py 94.24% <100.00%> (ø)
ldaptor/test/test_autofill_samba.py 100.00% <0.00%> (ø)
ldaptor/protocols/ldap/distinguishedname.py 89.09% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4bfe289...8e5a9e8. Read the comment docs.