twisted / mantissa

Divmod Mantissa is an application server with a web interface built using Axiom and Nevow.
MIT License
5 stars 10 forks source link

Overhaul Mantissa HTTPS support #67

Open mithrandi opened 7 years ago

mithrandi commented 7 years ago

Currently Mantissa jumps through a lot of hoops to generate URLs with HTTPS when redirecting from HTTP, but only when logging in, etc. These hoops represent some rather outdated ideas about HTTPS; there isn't really any reason to serve only logged in stuff over HTTPS instead of just serving the whole site over HTTPS. I think we should instead have Mantissa only serve Mantissa web functionality over one port (be it HTTP or HTTPS; HTTP behind a TLS terminating proxy is a pretty common use case that we should still support), and if you want HTTP to HTTPS redirection we can have a site that specifically just redirects which you could hook up to an HTTP port.

This would remove the need for Mantissa to look for an SSLPort to redirect to, which currently breaks sites using EndpointPort, which we made the default. Oops.