search

twisted / mantissa

Divmod Mantissa is an application server with a web interface built using Axiom and Nevow.
MIT License
5 stars 10 forks source link

Performance test unexpected success in scrolltable #7

Open mithrandi opened 9 years ago

mithrandi commented 9 years ago 
[SUCCESS!?!]
Reason: 'Index scan to find appropriate storeID starting point once the value index has been used to seek to /near/ the correct starting place causes this to be O(N) on the number of rows with duplicate values.'

xmantissa.test.test_scrolltable.InequalityPerformanceTests.test_rowsAfterItemWithDuplicatesAtStart
xmantissa.test.test_scrolltable.InequalityPerformanceTests.test_rowsBeforeItemWithDuplicatesAtStart

This is probably not worth spending any brain cycles on since I think the plan was to deprecate scrolltable anyway.

mithrandi commented 9 years ago

Oh, it was tdb that was going to be deprecated, not scrolltable. Well, maybe the .todo attribute should just be removed from these tests? I guess the SQLite query optimizer got smarter or something, although I think that just means the test isn't testing what it thinks it is anymore :/

mithrandi commented 9 years ago

Turns out these tests don't failunexpectedly succeed on the older version of SQLite that Travis has.