search

twisted / pydoctor

This is pydoctor, an API documentation generator that works by static analysis.
https://pydoctor.readthedocs.io
Other
179 stars 48 forks source link

Use stricter verifications before marking an attribute as constant #710

Closed tristanlatr closed 10 months ago

tristanlatr commented 1 year ago

Fixes #623

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 97.67% and project coverage change: +0.04% :tada:

Comparison is base (44a1a39) 92.62% compared to head (a023a96) 92.66%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #710 +/- ## ========================================== + Coverage 92.62% 92.66% +0.04% ========================================== Files 47 47 Lines 8132 8164 +32 Branches 1944 1954 +10 ========================================== + Hits 7532 7565 +33 Misses 343 343 + Partials 257 256 -1 ``` | [Files Changed](https://app.codecov.io/gh/twisted/pydoctor/pull/710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=twisted) | Coverage Δ | | |---|---|---| | [pydoctor/astutils.py](https://app.codecov.io/gh/twisted/pydoctor/pull/710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=twisted#diff-cHlkb2N0b3IvYXN0dXRpbHMucHk=) | `92.89% <94.44%> (+0.08%)` | :arrow_up: | | [pydoctor/astbuilder.py](https://app.codecov.io/gh/twisted/pydoctor/pull/710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=twisted#diff-cHlkb2N0b3IvYXN0YnVpbGRlci5weQ==) | `96.62% <98.27%> (+0.23%)` | :arrow_up: | | [pydoctor/epydoc/markup/\_pyval\_repr.py](https://app.codecov.io/gh/twisted/pydoctor/pull/710?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=twisted#diff-cHlkb2N0b3IvZXB5ZG9jL21hcmt1cC9fcHl2YWxfcmVwci5weQ==) | `92.87% <100.00%> (+0.11%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tristanlatr commented 1 year ago

I’de like a review on this PR before merging it.

tristanlatr commented 10 months ago

Thanks for your review @glyph, this should fix a couple of warnings triggered during the twisted build.

glyph commented 10 months ago

Thanks for your review @glyph, this should fix a couple of warnings triggered during the twisted build.

no worries @tristanlatr , thank you for your tireless efforts here!

tristanlatr commented 10 months ago

Your welcome, idk why but the ci has decided to be angry today :/

tristanlatr commented 10 months ago

Ok, merging this.