Closed tristanlatr closed 10 months ago
Patch coverage: 100.00%
and no project coverage change.
Comparison is base (
965ed95
) 92.62% compared to head (38ff2af
) 92.62%.:exclamation: Current head 38ff2af differs from pull request most recent head 8ec066f. Consider uploading reports for the commit 8ec066f to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I can't reproduce the current issue locally, tox -e test -- pydoctor/test/test_model.py::test_introspection_extension
works on my local machine :/
Only python3.10 and 3.11 are failing :/ so weird.
Any clue @adiroiban @glyph ?
@tristanlatr the first thing to investigate here is to make sure that mypy
and all its transitive dependencies are pinned.
Once we know that the environment is consistent everywhere I can investigate if something trickier is going on :)
I’m not talking about the mypy failure, but rather the unit tests failure on python 3.10 and 3.11. Mypy errors are obvious to fix and I will get to that later
I’m not talking about the mypy failure, but rather the unit tests failure on python 3.10 and 3.11.
Ah. Hm. I don't know enough about pydoctor's extension-module introspection capabilities, but surely there's something in the stdlib that we could use that's known to be an extension module and that doesn't depend on the sad little https://pypi.org/project/cython-test-exception-raiser/ project? It occurs to me that there's a 1.0.2, and I don't know what's in the chnagelog there, but maybe pinning the old version is part of the problem?
(debugging this for far too long right now I was not able to figure out what's going on)
Thanks for your help. Maybe the cProfile module can be used instead.
The cython function is not recognized because it's not actually a function object for pydoctor.
>>> type(cython_test_exception_raiser.raiser.raiseException).__mro__
(<class '_cython_3_0_2.cython_function_or_method'>, <class 'object'>)
I'll prepare a fix.