Closed tristanlatr closed 10 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
f54b6ef
) 92.69% compared to head (0db668f
) 92.69%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
According to pydoctor_primer, this change doesn't affect type check results on a corpus of open source code. ✅
According to pydoctor_primer, this change doesn't affect type check results on a corpus of open source code. ✅
@glyph would you be ok that I transfert the pydoctor_primer repository to the twisted org ?
@glyph would you be ok that I transfert the pydoctor_primer repository to the twisted org ?
sounds good
According to pydoctor_primer, this change doesn't affect type pydoctor output on a corpus of open source code. ✅
Diff from pydoctor_primer, showing the effect of this PR on open source code:
pydoctor (https://github.com/twisted/pydoctor): typechecking got 2.06x slower (33.0s -> 68.0s)
(Performance measurements are based on a single noisy sample)
According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅
According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅
Would be cool to have a diff of the generated html pages as well. But the setup here would be essentially the same. So I’ll merge this PR and open a few issue on the pydoctor_primer repo.
According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅