Closed tristanlatr closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
1b66928
) 92.69% compared to head (abb5b87
) 92.69%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Rendered changes can be reviewed here: https://pydoctor--760.org.readthedocs.build/en/760/contrib.html
According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅
@buhtz you can review this change, thanks
According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅
According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅
The information from primer and codecov might be useful for maintainers but not for extern contributors. It just blows up the discussion with noise and drive less experienced contributors away.
Even external contributors should be aware of the missing coverage lines or the potential new warnings triggered after a their changes. So I’de say it’s still relevant.
Diff from pydoctor_primer, showing the effect of this PR on open source code:
sdk-python (https://github.com/temporalio/sdk-python): typechecking got 1.12x slower (123.8s -> 138.2s)
(Performance measurements are based on a single noisy sample)
docutils (https://github.com/docutils/docutils): typechecking got 1.13x slower (81.6s -> 92.4s)
(Performance measurements are based on a single noisy sample)
twisted (https://github.com/twisted/twisted): typechecking got 1.08x slower (232.5s -> 251.0s)
(Performance measurements are based on a single noisy sample)
According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅
fixes #752 fixes #753 fixes #756 fixes #757