twisted / pydoctor

This is pydoctor, an API documentation generator that works by static analysis.
https://pydoctor.readthedocs.io
Other
184 stars 49 forks source link

Release pydoctor 24.3.0 #767

Closed tristanlatr closed 4 months ago

tristanlatr commented 6 months ago

Fixes #794

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.62%. Comparing base (27f5d4d) to head (30c00ab). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #767 +/- ## ========================================== + Coverage 92.56% 92.62% +0.05% ========================================== Files 47 47 Lines 8393 8393 Branches 1850 1850 ========================================== + Hits 7769 7774 +5 + Misses 359 356 -3 + Partials 265 263 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 6 months ago

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

github-actions[bot] commented 6 months ago

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

github-actions[bot] commented 6 months ago

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

github-actions[bot] commented 5 months ago

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

github-actions[bot] commented 5 months ago

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

github-actions[bot] commented 5 months ago

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

github-actions[bot] commented 4 months ago

Diff from pydoctor_primer, showing the effect of this PR on open source code:

sphinx (https://github.com/sphinx-doc/sphinx): typechecking got 1.10x slower (131.8s -> 144.8s)
(Performance measurements are based on a single noisy sample)
tristanlatr commented 4 months ago

Releasing a new version of pydoctor @glyph @adiroiban.

github-actions[bot] commented 4 months ago

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

github-actions[bot] commented 4 months ago

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

github-actions[bot] commented 4 months ago

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

github-actions[bot] commented 4 months ago

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

adiroiban commented 4 months ago

Hi @tristanlatr I have pushed a change to publish the packagte using PyPI Trusted Publishers API

The PyPI changes were made here https://pypi.org/manage/project/pydoctor/settings/publishing/#errors

image


I think that only Twisted Organization admins have permissions to PyPI manager... but now, any package published from unit.yaml is accepted by PyPI.


Feel free to create a tag based on the latest commit from this PR.

It should trigger a PyPi package publishing.

Thanks

adiroiban commented 4 months ago

I have also removed the PYPI_TOKEN token from secrets as it should never be used again

github-actions[bot] commented 4 months ago

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

github-actions[bot] commented 4 months ago

Diff from pydoctor_primer, showing the effect of this PR on open source code:

numpy (https://github.com/numpy/numpy): typechecking got 1.13x slower (185.8s -> 210.2s)
(Performance measurements are based on a single noisy sample)
adiroiban commented 4 months ago

I have removed the ubuntu 20.04 required jobs as it looks like it is no longer used.

image


tristanlatr commented 4 months ago

Thanks a lot Adi, I’ll try again

tristanlatr commented 4 months ago

Looks like it failed...

Error: Trusted publishing exchange failure: 
OpenID Connect token retrieval failed: GitHub: missing or insufficient OIDC token permissions, the ACTIONS_ID_TOKEN_REQUEST_TOKEN environment variable was unset

This generally indicates a workflow configuration error, such as insufficient
permissions. Make sure that your workflow has `id-token: write` configured
at the job level, e.g.:

``yaml
permissions:
  id-token: write
``

Learn more at https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/about-security-hardening-with-openid-connect#adding-permissions-settings.

Full log: https://github.com/twisted/pydoctor/actions/runs/9098901922/job/25010411600

@adiroiban

github-actions[bot] commented 4 months ago

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

adiroiban commented 4 months ago

True. My bad.

I have added explicit job permissions.

You can delete the tag and create it again. It should re-trigger the job

github-actions[bot] commented 4 months ago

Diff from pydoctor_primer, showing the effect of this PR on open source code:

numpy (https://github.com/numpy/numpy): typechecking got 1.12x slower (175.6s -> 196.2s)
(Performance measurements are based on a single noisy sample)
tristanlatr commented 4 months ago

Still not working @adiroiban

ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/        
         Can't have direct dependency: twisted@                                 
         git+https://github.com/twisted/twisted.git ; extra == "mypy". See      
         https://packaging.python.org/specifications/core-metadata for more     
         information.  
github-actions[bot] commented 4 months ago

Diff from pydoctor_primer, showing the effect of this PR on open source code:

sphinx (https://github.com/sphinx-doc/sphinx): typechecking got 1.07x faster (147.7s -> 137.5s)
(Performance measurements are based on a single noisy sample)

numpy (https://github.com/numpy/numpy): typechecking got 1.14x slower (184.2s -> 210.7s)
(Performance measurements are based on a single noisy sample)
adiroiban commented 4 months ago

The pypi publishing works.

The package was rejected due to setup.cfg deps definition

https://github.com/twisted/pydoctor/blob/27f5d4d022c9e1194f6ef82d49642c7966969fa5/setup.cfg#L82


It looks like we need to do a release for Twisted.

Why do we need the latest Twisted here ?

tristanlatr commented 4 months ago

I think we don’t need it anymore

github-actions[bot] commented 4 months ago

Diff from pydoctor_primer, showing the effect of this PR on open source code:

numpy (https://github.com/numpy/numpy): typechecking got 1.15x slower (182.1s -> 209.2s)
(Performance measurements are based on a single noisy sample)
github-actions[bot] commented 4 months ago

Diff from pydoctor_primer, showing the effect of this PR on open source code:

numpy (https://github.com/numpy/numpy): typechecking got 1.12x slower (185.4s -> 208.4s)
(Performance measurements are based on a single noisy sample)
github-actions[bot] commented 4 months ago

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

github-actions[bot] commented 4 months ago

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

github-actions[bot] commented 4 months ago

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅