RFE: please provide update for `urllib3` 2.2.x

twisted / pydoctor

This is pydoctor, an API documentation generator that works by static analysis.

https://pydoctor.readthedocs.io/

Other

179 stars 47 forks source link

RFE: please provide update for `urllib3` 2.2.x #776

Closed kloczek closed 2 months ago

kloczek commented 2 months ago

Latest version of the urllib3` is 2.2.1. https://github.com/twisted/pydoctor/blob/fe29bb791af4459c07bdab3da8916a1b31f6f3b6/setup.cfg#L42

kloczek commented 2 months ago

It would be good to release new version out of already committed changes as lates sphinx fixes have been already added. Doable? 🤔

tristanlatr commented 2 months ago

Hello @kloczek,

I'm afraid I don't understand your point about sphinx files. Regarding the urllib3 dependency pin, I believe we can totally remove version pin since we don't support python3.6 anymore.

kloczek commented 2 months ago

Regarding the urllib3 dependency pin, I believe we can totally remove version pin since we don't support python3.6 anymore.

[tkloczko@pers-jacek SPECS]$ grep 'BuildRequires:.*python3dist(urllib3)' *
python-elastic-transport.spec:BuildRequires:    python3dist(urllib3) 
python-geventhttpclient.spec:BuildRequires:     python3dist(urllib3)
python-httpretty.spec:BuildRequires:  python3dist(urllib3)
python-pyppeteer.spec:BuildRequires:    python3dist(urllib3)
python-requests-file.spec:BuildRequires:        python3dist(urllib3)
python-requests.spec:BuildRequires:     python3dist(urllib3)
python-selenium.spec:BuildRequires:     python3dist(urllib3)
python-seleniumbase.spec:BuildRequires: python3dist(urllib3)

Hmm it means that as I'm on python 3.11 I must check above packages build dependencies to probably remove urllib3 from packaging BRs and install time dependencies 🤔

tristanlatr commented 2 months ago

Sorry I still don’t understand your declaration. My understanding is the following:

you package bunch of python modules as rpm packages with pydoctor as a build dependency
Urllib is a build dependency of some package and a dependency of pydoctor so you end up with the highest compatible version

Please correct me if I’m misunderstanding.

The pin on the special urllib version is not necessary anymore for pydoctor. We should just remove it leave it unspecified. This should solve your issue, right ?

kloczek commented 2 months ago

That is correct and from your comment I've learned that I can remove from your module and few other build procedures urllib3 module which makes my RFE a bit pointless. Thank you very much 👍 😄

Feel free to close this ticket or keep until you will remove urllib3 dependency as well 🙄