search

twisted / pydoctor

This is pydoctor, an API documentation generator that works by static analysis.
https://pydoctor.readthedocs.io/
Other
179 stars 47 forks source link

Follow-up on #780 #784

Closed tristanlatr closed 2 months ago

tristanlatr commented 2 months ago

Fix the function to upgrade annotations. Respect annotations rules like in our linker.

github-actions[bot] commented 2 months ago

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

github-actions[bot] commented 2 months ago

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 84.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 92.64%. Comparing base (3337d57) to head (d8bcabf).

Files Patch % Lines
pydoctor/astutils.py 63.63% 2 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #784 +/- ## ========================================== - Coverage 92.67% 92.64% -0.04% ========================================== Files 47 47 Lines 8373 8384 +11 Branches 1844 1848 +4 ========================================== + Hits 7760 7767 +7 - Misses 353 355 +2 - Partials 260 262 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 months ago

Diff from pydoctor_primer, showing the effect of this PR on open source code:

numpy (https://github.com/numpy/numpy): typechecking got 1.06x slower (204.6s -> 217.2s)
(Performance measurements are based on a single noisy sample)
github-actions[bot] commented 2 months ago

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅