twisted / towncrier

Manage the release notes for your project.

https://towncrier.readthedocs.io

MIT License

755 stars 107 forks source link

Release 23.6.0 #515

Closed adiroiban closed 1 year ago

adiroiban commented 1 year ago

Description

This is the release PR for 23.6.0

Fixes #514 and while doing this release we will test the new publishing method.

This is also the last release for python 3.7. This is done to simplify our code.

I am just following the info from RELEASE.rst

adiroiban commented 1 year ago

needs-review

hynek commented 1 year ago

Just double-checking: is OIDC already configured for towncrier in PyPI? I don't think I've received and email about that. 🤔

adiroiban commented 1 year ago

I am reading the docs and the initial announcement here https://blog.pypi.org/posts/2023-04-20-introducing-trusted-publishers/ and my understanding is that OIDC is already enabled for all repos that are hosted on GitHub.

For now, only GitHub is supported :( ... but we are on GitHub, so this doesn't affects us.

hynek commented 1 year ago

It is enabled, but you still have to set some settings.

The project view has look something like this:

If it doesn't, you just have to fill out this form:

adiroiban commented 1 year ago

I see... I don't have admin rights to towncrier in PyPi... the release just worked with the token from GitHub Secrets.

I will see if I/we can get admin rights for towncrier in PyPI

hynek commented 1 year ago

@glyph? 😇

glyph commented 1 year ago

the twisted core team is now an owner of the towncrier project.

adiroiban commented 1 year ago

Thanks @glyph . I have access twisted/towncrier and I have created the GitHub publisher.

But I still don't have access twisted/twisted

glyph commented 1 year ago

OK I guess the 'maintainer' role isn't sufficient for most tasks. I promoted 'core' to 'owner' on twisted/twisted

adiroiban commented 1 year ago

I think this is ready for review.

The release notes are now visible in HTML format

https://towncrier--515.org.readthedocs.build/en/515/release-notes.html#

please review

adiroiban commented 1 year ago

Yes. We definitely need to move the release/publish in a separate workflow.

The current workflow is confusing.

so ... release candidate is on pypi - https://pypi.org/project/towncrier/23.6.0rc1/

Published here - https://github.com/twisted/towncrier/actions/runs/5188156080/jobs/9351471004

I will prepare the final release

hynek commented 1 year ago

so ... release candidate is on pypi - https://pypi.org/project/towncrier/23.6.0rc1/

Published here - https://github.com/twisted/towncrier/actions/runs/5188156080/jobs/9351471004

Happy to see it worked out!

I will prepare the final release

Thanks for doing this!

adiroiban commented 1 year ago

I have created a separate ticket to discuss moving the release in a separate file #519

final release done here https://github.com/twisted/towncrier/actions/runs/5200182732

The package is published https://pypi.org/project/towncrier/23.6.0/

I will now set the dev version and merge this PR.

Thanks for your help

adiroiban commented 1 year ago

I have removed the PYPI_TOKEN secret from here https://github.com/twisted/towncrier/settings/secrets/actions ... this is the GHA side.

But I don't know where this token is defined inside PyPI. I see that on GHA it was created on Updated on Dec 9, 2020 I can also see the log on PyPI with the token creation by @glyph - https://pypi.org/manage/project/towncrier/history/?page=2

Maybe the token is hosted in Glyphs PyPI profile. Glyph, if you can find the Towncrier PyPI token , you can delete it :)