twisted / towncrier

Manage the release notes for your project.

https://towncrier.readthedocs.io

MIT License

755 stars 107 forks source link

Fix incorrect handling of orphan fragment names consists of only digits #588

Closed SmileyChris closed 2 months ago

SmileyChris commented 2 months ago

Fixes #584

Checklist

[x] Make sure changes are covered by existing or new tests.
[x] For at least one Python version, make sure local test run is green.
[x] Create a file in src/towncrier/newsfragments/. Describe your change and include important information. Your change will be included in the public release notes.
[x] Make sure all GitHub Actions checks are green (they are automatically checking all of the above).

SmileyChris commented 2 months ago

Looking closer the true source of the error is because strip_if_integer_string reads the orphan of +12345 as an actual integer, stripping off the '+', causing this issue to lose its status as an orphan!

SmileyChris commented 2 months ago

There, that's tidier!

adiroiban commented 2 months ago

It looks good. I have enabled auto-merge.

Thanks for your help.

I am happy to review and approve a PR that add more tests... but that should not be a blocker for this PR.