Allow overriding of the default Content-Type in POST and PUT

twisted / treq

Python requests like API built on top of Twisted's HTTP client.

Other

587 stars 139 forks source link

Allow overriding of the default Content-Type in POST and PUT #301

Closed mattwwarren closed 2 years ago

mattwwarren commented 3 years ago

I noticed #297 was merged and wanted to get this up for review before a release with that change, since it would break our current code. Thanks in advance for the review, this is my first PR here so please don't hold back!

twm commented 3 years ago

Hi @mattwwarren, thank you for diving in here! I may not get to a full review before the weekend but I did a quick skim. Apart from the boundary thing I noted above, tests should have docstrings (yeah, not all of the ones there do...). https://jml.io/pages/test-docstrings.html is a good guide to this.

glyph commented 3 years ago

Hi @mattwwarren ! Just bumping this to see if you've still got interest. I know it's been a heck of a year but I think we're still interested in integrating this PR.

glyph commented 2 years ago

Closing this to clean up the review queue. If anyone is interested in picking up the work, feel free to reopen.