search

twisted / treq

Python requests like API built on top of Twisted's HTTP client.
Other
587 stars 140 forks source link

Cleanup: remove bytes decoding for quoted result #332

Closed laggardkernel closed 2 years ago

laggardkernel commented 3 years ago

Remove byte decoding for return value of quote_plus(). Not needed after we dropped Python 2 support.

laggardkernel commented 3 years ago

@graingert You mean I'd better separate these typo fix in the doc into another PR, or just another commit?

graingert commented 3 years ago

@graingert You mean I'd better separate these typo fix in the doc into another PR, or just another commit?

I'd prefer a commit with the typo fix, a commit with the bugfix and a commit with the docs fix

laggardkernel commented 3 years ago

Update: rebased onto HEAD of master.

Okay. Separated into 2 commits

glyph commented 2 years ago

@graingert It's not enough to approve non-members' PRs, you gotta approve 'em :).

I am ignoring Coveralls' whinging here because it's just noticing that there are fewer lines of code; our thresholds are wrong and we should fix that.