search

twisted / treq

Python requests like API built on top of Twisted's HTTP client.
Other
585 stars 137 forks source link

Handle exceptions raised from the collector passed to treq.content() #348

Closed itamarst closed 1 year ago

itamarst commented 2 years ago

Fixes #347

itamarst commented 1 year ago

I have addressed both comments. I don't have commit access, though, so someone else will have to merge once tests pass.

itamarst commented 1 year ago

And a maintainer will need to approve test run too.

itamarst commented 1 year ago

OK, can be merged now.

twm commented 1 year ago

I don't have commit access, though, so someone else will have to merge once tests pass.

Yikes, I didn't realize! Shall I add you as a maintainer?

adiroiban commented 1 year ago

I have invited Itamar to https://github.com/orgs/twisted/teams/twisted-contributors/members

I don't know why not already in the team.

With that, you get access to Treq, but also other Twisted org projects

itamarst commented 1 year ago

https://www.youtube.com/watch?v=UPw-3e_pzqU