Closed twm closed 2 months ago
Thank you for the review @adiroiban!
I would love to have it integrated in twisted/twisted
There are certainly parts of it that could live in twisted/twisted:
RequestTraversalAgent
(I've often taken a treq dep just for this)treq.content
treq.auth
MultiPartProducer
(if its bugs were fixed)Some parts that are iffy:
HTTPClient
Agent
)_Response
type duplicates treq.content
API surface and also buffers the response by defaultFinally there some parts that I'd never put in twisted/twisted:
treq.request()
, treq.get()
, etc.)requests
dependencyStubTreq
(this should be a helper function that returns an appropriately-configured HTTPClient
)Thanks again Adi!
Thanks for the info related to having treq code in twisted/twisted
I think merging parts of treq into twisted/twisted is a better approach.
Fixes #382.