Revert "HTTP Digest Authentication support" (#267)

twisted / treq

Python requests like API built on top of Twisted's HTTP client.

Other

585 stars 137 forks source link

Revert "HTTP Digest Authentication support" (#267) #390

Closed twm closed 3 weeks ago

twm commented 3 weeks ago

This reverts commit 22a776ddb32f1ff2d141c2fa8b4a47b2a11307f5, reversing changes made to c9f0baed7eeb9b8056bbdab387470de244b031fd.

Per 2024-06-28 discussion in #twisted on libera.chat and post-merge review comments on GitHub, this implementation doesn't look spec compliant.

I have filed #389 to track adding this feature.

glyph commented 3 weeks ago

Yep, my approval was a bit overzealous. While I appreciate @jameshilliard's work and didn't want to delay further, there were gaps in the previous reviews that we should address.