search

twisted / twisted-dev-tools

Tools for twisted development.
7 stars 8 forks source link

Have a single view of all pending reviews for Twisted #11

Open adiroiban opened 9 years ago

adiroiban commented 9 years ago

We do have https://twistedmatrix.com/trac/report/25

but we also have twisted-infra/* and twisted/twistedchecker and twitsted/twisted-dev-tools which gets PRs

For GitHub I was able to create this query:

https://github.com/pulls?q=is%3Aopen+is%3Apr+repo%3Atwisted%2Ftwistedchecker+repo%3Atwisted%2Ftwisted-dev-tools+user%3Atwisted-infra+

which is in fact

is:open is:pr repo:twisted/twistedchecker repo:twisted/twisted-dev-tools user:twisted-infra

We can argue that twistedchecker and twisted-dev-tools should be part of twisted main repo as I have no idea who would want to use them outside of twisted.

In this case the filter would be much easier and we would only have twisted-infra reviews

I would like to see all these PR in a single place, for example here https://twistedmatrix.com/trac/report/25

I am thinking of updating the Trac theme so that when the url is report/25 it will do an Ajax request and insert those issues into the report with links to github.

@hynek What do you think?

In this way PR as https://github.com/twisted-infra/t-web/pull/7 should be much visible.

Maybe this should be filled in twisted-infra/trac but I feel that this is an important dev tool :)

hynek commented 9 years ago

My uninformed questions would be:

Having those two would make it trivial to implement…

adiroiban commented 9 years ago

GitHub API is great - and we can use Issues search for that - https://developer.github.com/v3/search/#search-issues

has trac something similar?

I don't understand the question...but I think that GitHub API is enough and we can fill the Trac report either on server or client side.

My idea was to do it on client side to reduce load on the server

hynek commented 9 years ago

My question was whether Trac has a search API or whether we have to parse HTML output of the report if we want to create a dashboard that contains both Trac and GitHub issues.

adiroiban commented 9 years ago

There is Trac XML-PRC api but I don't know if we want to enable it and I don't think that we need it.

I was just thinking to inject those links into the Trac report page https://twistedmatrix.com/trac/report/25

tomprince commented 9 years ago

There is an AMP ednpoint that talks to trac; although perhaps it isn't worth the effort to continue to maintain it?