lineLengthExceeded behaviour varies between LineReceiver and LineOnlyReceiver

twisted-trac commented 16 years ago

	spiv reported
Trac ID	trac#3353
Type	defect
Created	2008-07-13 14:18:20Z

I'm experimenting with a patch to improve the tests for LineReceiver/LineOnlyReceiver, based on how bzrlib tests some things. Specifically, I'm applying the same test case to two different implementations of the one interface: LineOnlyReceiver and LineReceiver.

This has revealed some inconsistencies with how LineReceiver and LineOnlyReceiver handle lineLengthExceeded:

LineOnlyReceiver.lineLengthExceeded doesn't actually call loseConnection, it just returns a ConnectionError as if it had.
lineLengthExceeded is invoked with a different string in some cases when MAX_LENGTH is exceeded.

The attached patch to test_protocols shows these test failures. (This patch is relative to my patch on [#3277](https://github.com/twisted/twisted/issues/3277), but it's also a bzr merge directive with full history vs. trunk).

As mentioned in #3277, I think lineLengthExceeded isn't a fully baked API, and these inconsistencies are symptoms of that.

Attachments:

lineReceiver-implementation-tests.patch (11880 bytes) - added by spiv on 2008-07-13 14:18:57Z - Work-in-progress experiment that shows the inconsistent behaviour via test failures.

Searchable metadata

``` trac-id__3353 3353 type__defect defect reporter__spiv spiv priority__normal normal milestone__ branch__ branch_author__ status__new new resolution__None None component__core core keywords__ time__1215958700000000 1215958700000000 changetime__1246348604000000 1246348604000000 version__None None owner__ cc__ivank ```

twisted-trac commented 15 years ago

	@glyph set owner to spiv

twisted-trac commented 13 years ago

	Automation removed owner

twisted-trac commented 16 years ago

	amaury commented

LineOnlyReceiver.lineLengthExceeded doesn't actually call loseConnection

I think it should; is there any reason why LineOnlyReceiver and LineReceiver differ on this point?

The corresponding test has to be changed as well: the last line of testLineTooLong() could be:

self.assertTrue(a.transport.closed)

twisted / twisted

lineLengthExceeded behaviour varies between LineReceiver and LineOnlyReceiver #3353