fix using externally-defined decorator

twisted / twistedchecker

twistedchecker is a tool to automatically verify code against the Twisted coding standard.

MIT License

9 stars 13 forks source link

fix using externally-defined decorator #114

Closed glyph closed 8 years ago

glyph commented 8 years ago

If you use a decorator defined somewhere that twistedchecker can't "see", it fails with an exception.

This currently causes linting of twisted.internet.endpoints, twisted.web.client, twisted.web.http, and twisted.mail.test.test_smtp to fail with:

Traceback (most recent call last):
  File ".../twistedchecker/checkers/docstring.py", line 68, in _isSetter
    if '.setter' in name:
TypeError: argument of type '_Yes' is not iterable

which may be obfuscating further lint errors.

codecov-io commented 8 years ago

Current coverage is 70.22%

Merging #114 into master will decrease coverage by 0.09%

@@             master       #114   diff @@
==========================================
  Files            62         62          
  Lines          1520       1525     +5   
  Methods           0          0          
  Messages          0          0          
  Branches        199        200     +1   
==========================================
+ Hits           1069       1071     +2   
- Misses          414        417     +3   
  Partials         37         37

Powered by Codecov. Last updated by 7c0b4ca...9cec9f5

glyph commented 8 years ago

Anybody feel like doing an actual review? :)

glyph commented 8 years ago

This PR fixes #111

adiroiban commented 8 years ago

Look good. Will merge. Thanks! We need to do a release... which should be done automatically by creating a tag.

glyph commented 8 years ago

Thanks a bunch for the review @adiroiban !