twisted / twistedchecker

twistedchecker is a tool to automatically verify code against the Twisted coding standard.
MIT License
9 stars 13 forks source link

Warn about use of deprecated assertion methods #59

Closed ghost closed 10 years ago

ghost commented 10 years ago

It might be worth adding warnings about the use of deprecated assertion methods while we're waiting for them to be actually deprecated, so people don't accidentally use them.

Once they are all deprecated, this won't be necessary because they will print deprecation warnings which will be picked up by trial.


Imported from Launchpad using lp2gh.

ghost commented 10 years ago

(by exarkun) This is what PendingDeprecationWarning is for. twistedchecker is the wrong tool for this. Suggest close as wontfix.

ghost commented 10 years ago

(by richardw) I agree. Lets close this. I opened the ticket, but don't seem to have permission to close it.

14:47 < rwall> exarkun: In https://bugs.launchpad.net/twistedchecker/+bug/1226835 you mention PendingDeprecationWarning 14:48 < rwall> Shall I create a ticket to add PendingDeprecationWarning to all the affected assertions? 14:50 < rwall> Actually, no that's just going to cause all the same warnings as a standard deprecation 14:50 < rwall> https://twistedmatrix.com/trac/ticket/4990 14:52 < rwall> Sorry https://twistedmatrix.com/trac/ticket/4991 14:53 < exarkun> Ah that's less confusing. 14:54 < exarkun> Do I think that #4991 should be resolved? Sure, that'd be great. :) 14:54 < exarkun> (as long as Twisted itself has stopped using the deprecated APIs) 14:55 < rwall> So your point is, don't waste time adding new checks to twistedchecker, just do the work of replacing and then deprecating the old assertions. 14:56 < exarkun> well, I like that point, but I don't think it's the one I was making 14:56 -!- khorn1 [~