Refactored Authv4 code to make the logic more easily reusable

twisted / txaws

Twisted-based Asynchronous Libraries for Amazon Web Services and clouds that support the AWS APIs

MIT License

32 stars 18 forks source link

Refactored Authv4 code to make the logic more easily reusable #33

Closed exarkun closed 7 years ago

exarkun commented 7 years ago

To support upcoming attempts to add Route53 support, the recently added (and wonderful) Authv4 features should be refactored a bit to shift move logic up to the base classes and away from the S3-specific code.

Here is some refactoring.

Note this is still a little rough (eg missing docstrings, possibly missing test coverage). Feel free to wait until I do a little more polish before reviewing - but early thoughts appreciated as well!

codecov-io commented 7 years ago

Current coverage is 95.89% (diff: 96.58%)

Merging #33 into master will decrease coverage by 0.28%

@@             master        #33   diff @@
==========================================
  Files            61         62     +1   
  Lines          7804       7948   +144   
  Methods           0          0          
  Messages          0          0          
  Branches        487        531    +44   
==========================================
+ Hits           7506       7622   +116   
- Misses          193        205    +12   
- Partials        105        121    +16

Powered by Codecov. Last update ca9aab1...1cc32cd