search

twisted / txaws

Twisted-based Asynchronous Libraries for Amazon Web Services and clouds that support the AWS APIs
MIT License
32 stars 18 forks source link

Credentials error #53

Closed Julian closed 7 years ago

Julian commented 7 years ago

This changeset stacks after #52

codecov[bot] commented 7 years ago

Codecov Report

Merging #53 into master will decrease coverage by 0.42%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   96.35%   95.92%   -0.43%     
==========================================
  Files          74       74              
  Lines        8884     8892       +8     
  Branches      626      626              
==========================================
- Hits         8560     8530      -30     
- Misses        202      231      +29     
- Partials      122      131       +9
Impacted Files Coverage Δ
txaws/exception.py 89.13% <100%> (+0.11%) :arrow_up:
txaws/credentials.py 94.11% <100%> (+0.36%) :arrow_up:
txaws/ec2/tests/test_client.py 99.67% <100%> (ø) :arrow_up:
txaws/tests/test_credentials.py 100% <100%> (ø) :arrow_up:
txaws/route53/client.py 87.5% <0%> (-12.5%) :arrow_down:
txaws/testing/integration.py 78.57% <0%> (-7.15%) :arrow_down:
txaws/service.py 87.61% <0%> (-6.67%) :arrow_down:
txaws/client/ssl.py 71.25% <0%> (-3.75%) :arrow_down:
txaws/client/base.py 88.17% <0%> (-2.03%) :arrow_down:
txaws/s3/client.py 94.08% <0%> (-0.81%) :arrow_down:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f0301bd...7f9aa1a. Read the comment docs.

Julian commented 7 years ago

Addressed the 2 style + grammar stuffz, lemme know what you have in mind for the docstring note.