twisted / txaws

Twisted-based Asynchronous Libraries for Amazon Web Services and clouds that support the AWS APIs
MIT License
32 stars 18 forks source link

Global os.environ usage begone. #56

Closed Julian closed 7 years ago

Julian commented 7 years ago

No more use of global os.environ in credentials.

codecov[bot] commented 7 years ago

Codecov Report

Merging #56 into master will decrease coverage by 0.43%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   96.35%   95.92%   -0.44%     
==========================================
  Files          74       74              
  Lines        8924     8910      -14     
  Branches      628      628              
==========================================
- Hits         8599     8547      -52     
- Misses        202      231      +29     
- Partials      123      132       +9
Impacted Files Coverage Δ
txaws/tests/test_credentials.py 100% <100%> (ø) :arrow_up:
txaws/credentials.py 92.85% <100%> (ø) :arrow_up:
txaws/route53/client.py 87.5% <0%> (-12.5%) :arrow_down:
txaws/testing/integration.py 78.57% <0%> (-7.15%) :arrow_down:
txaws/service.py 87.61% <0%> (-6.67%) :arrow_down:
txaws/client/ssl.py 71.25% <0%> (-3.75%) :arrow_down:
txaws/client/base.py 88.17% <0%> (-2.03%) :arrow_down:
txaws/s3/client.py 94.08% <0%> (-0.81%) :arrow_down:
txaws/testing/route53_tests.py 99.34% <0%> (-0.66%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 27b7256...89fdd79. Read the comment docs.

exarkun commented 7 years ago

It looks like this stacks on #53, at least. Maybe also #54?

Julian commented 7 years ago

Yeah they're all in order, it stacks on both of those

exarkun commented 7 years ago

Great. Thank you. Merging.