search

twisted / txaws

Twisted-based Asynchronous Libraries for Amazon Web Services and clouds that support the AWS APIs
MIT License
32 stars 18 forks source link

test_ssl_hostname_verification honors its docstring. #73

Closed markrwilliams closed 7 years ago

markrwilliams commented 7 years ago

It asserts that the created Agent received an instance of twisted.internet.ssl.VerifyingContextFactory. This fixes an issue caused by Twisted 17.1.0 and later's use of HostnameEndpoint within t.w.client.Agent.

This test should be deleted as part of the deprecation process described in #47 (TLS support includes root certificate management code that should be handled elsewhere).

Closes #72.

codecov[bot] commented 7 years ago

Codecov Report

Merging #73 into master will decrease coverage by 0.48%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage    96.4%   95.92%   -0.49%     
==========================================
  Files          74       74              
  Lines        8906     8910       +4     
  Branches      629      630       +1     
==========================================
- Hits         8586     8547      -39     
- Misses        200      232      +32     
- Partials      120      131      +11
Impacted Files Coverage Δ
txaws/client/tests/test_base.py 97.46% <100%> (-0.82%) :arrow_down:
txaws/route53/client.py 87.5% <0%> (-12.5%) :arrow_down:
txaws/testing/integration.py 78.57% <0%> (-7.15%) :arrow_down:
txaws/service.py 87.61% <0%> (-6.67%) :arrow_down:
txaws/client/ssl.py 71.25% <0%> (-3.75%) :arrow_down:
txaws/client/base.py 88.25% <0%> (-2.69%) :arrow_down:
txaws/s3/client.py 94.08% <0%> (-0.81%) :arrow_down:
txaws/testing/route53_tests.py 99.34% <0%> (-0.66%) :arrow_down:
txaws/ec2/tests/test_client.py 99.59% <0%> (-0.09%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8127b45...b08a5e8. Read the comment docs.