Closed jwtrhs closed 5 years ago
Actually I've run into another error where the details
kwarg also isn't present on the BaseQuery
.
Is there supposed to be another interface between these two?
Looks like we were using a custom Query object for the query_factory
from an old version, all good!
I've been running into an issue using the S3 client on v0.5.0.
It seems
query_factory
method in the client is attempting to pass acredentials
kwarg to theBaseQuery
object, however it expects acreds
kwarg instead.https://github.com/twisted/txaws/blob/5c3317376cd47e536625027e38c3b37840175ce0/txaws/s3/client.py#L81-L82
https://github.com/twisted/txaws/blob/5c3317376cd47e536625027e38c3b37840175ce0/txaws/client/base.py#L633-L635
PR here if it helps: https://github.com/twisted/txaws/pull/98