twistedelectrons / TherapSID

Other
33 stars 5 forks source link

ADSR not responding v2.6 #108

Closed stanislavche closed 6 months ago

stanislavche commented 6 months ago

When I play throw midi (M8 -> Therapsid 1st Midi channel) ADSR setting not responding on the fly. I need to restart playback to hear this changes. I have received Therapsid yesterday it has 2.6 firmware from 1st of February. On Therapsid tool v1.2 I have set ADSR Bug: to fixed for both Sid. But it’s not helped. I have installed Swinsids in 6581 mode. Any ideas or solutions, may be this already been discussed?

thomasj commented 6 months ago

Hi!

This is normal for the SID, as you will need to restart playback to hear the changes of the envelope. The changes are written to the SID directly when changed.

Note that the Therapsid Tool (and TS) only supports special functionality/settings of the ARMSID chips. If there are special commands to Swinsid to disable ADSR bug, they are most likely not the same. However, the ADSR bug is not related to the issue you see.

Thereby, suggesting @twisted-electrons to close this issue as Invalid.

stanislavche commented 6 months ago

For those who play it from trackers or daw. If you want to hear changes on the fly don’t forget to send midi note off. In other case ADSR won’t respond till you stop playback.

beau-seidon commented 6 months ago

Does NoteOn&Vel=0 make it behave the same way as NoteOff? Or does it specifically need a NoteOff message?

thomasj commented 6 months ago

Yes, NoteOn with velocity 0 is handled as NoteOff.