search

twistedfall / opencv-rust

Rust bindings for OpenCV 3 & 4
MIT License
1.96k stars 157 forks source link

Return an error when the parsing has failed #577

Closed kino-ma closed 4 months ago

kino-ma commented 4 months ago

Hi maintainers! I encountered an issue while using this library, and tried to fix it. I'm sorry if this PR doesn't follow some rules, as I'm very new to contribute to OSSes. Please notify me if there's any missing information 🙏 Thank you!

Currently, probe_from_paths returns empty Version (i.e., 0.0.0) when it fails to guess the OpenCV version from header files. It causes an "Unsupported OpenCV version" error.

I saw the error because the function could not find version.hpp at the expected location. The root cause was the misconfiguration of include paths.

Instead, it will be more user-friendly if it explicitly reports an error.

twistedfall commented 4 months ago

Thanks a lot!

kino-ma commented 4 months ago

Thank you for merging! 🙏