twistlock / authz

Docker Authorization Plugin
Apache License 2.0
242 stars 80 forks source link

build instructions in README out of date - Missing godeps? #45

Open nicobrevin opened 7 years ago

nicobrevin commented 7 years ago

Hi there.

It looks like the README's build instructions are out of date. The instructions to use godep are now redundant as of ac5bea8355bf8f1620d8504265ad286e60daa9b8.

I'm a complete go noob, but I managed to get the project to build once I moved my git clone to $HOME/go/src/twistlock-authz - only then did it pick up the vendor directory. Is this something that all golangers know?

nicobrevin commented 7 years ago

Feel free to accept this patch :)

diff --git a/README.md b/README.md
index 877a2f1..ac1ee2a 100755
--- a/README.md
+++ b/README.md
@@ -57,12 +57,7 @@ Below are some examples for basic policy scenarios:
 ## Setting up local dev environment

   * Install [go 1.8](https://golang.org/dl/) and [docker](https://docs.docker.com/linux/step_one/).
-  * Install [godep](https://github.com/tools/godep).
-  * Clone the project.
-  * Restore go dependencies:
-```go
-  $ godep restore
-```
+  * Clone the project in to $HOME/go/src.
   * Build the binary and image:
 ```go
   $ make all