twitch-rs / twitch_api

Rust library for talking with the Twitch API aka. "Helix", TMI and more! Use Twitch endpoints fearlessly!
Apache License 2.0
151 stars 33 forks source link

Bump rustls and rustls-webpki #384

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 1 year ago

Bumps rustls-webpki from 0.100.1 to 0.100.2.

Release notes

Sourced from rustls-webpki's releases.

v/0.100.2

Release notes

  • certificate path building and verification is now capped at 100 signature validation operations to avoid the risk of CPU usage denial-of-service attack when validating crafted certificate chains producing quadratic runtime. This risk affected both clients, as well as servers that verified client certificates.

What's Changed

Full Changelog: https://github.com/rustls/webpki/compare/v/0.100.1...v/0.100.2

Commits
  • c8b8214 Bump MSRV to 1.60
  • 8557522 Avoid testing MSRV of dev-dependencies
  • 73a7f0c Cargo: version 0.100.1 -> 0.100.2
  • 4ea0523 verify_cert: enforce maximum number of signatures.
  • See full diff in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/twitch-rs/twitch_api/network/alerts).
Nerixyz commented 1 year ago

If CI works, this should be fine.

Nerixyz commented 1 year ago

Does this checkout the master branch?

error: 1 vulnerability found!
Crate:     rustls-webpki
Version:   0.101.1
Title:     rustls-webpki: CPU denial of service in certificate path building
Date:      2023-08-22
ID:        RUSTSEC-2023-0053
URL:       https://rustsec.org/advisories/RUSTSEC-2023-0053
Severity:  7.5 (high)
Solution:  Upgrade to >=0.100.2, <0.101.0 OR >=0.101.4
Dependency tree:
rustls-webpki 0.101.1
└── rustls 0.21.5
    └── ureq 2.7.1
        └── twitch_api 0.7.0-rc.6
            ├── twitch_oauth2-integration 0.1.0
            ├── tower_client 0.1.0
            ├── eventsub_websocket 0.1.0
            └── eventsub 0.1.0

https://github.com/twitch-rs/twitch_api/actions/runs/5942579782/job/16115842611?pr=384#step:4:23

Seems wrong - it was just updated.

Nerixyz commented 1 year ago

CI was right, rustls was still using an old version. I've updated it.

Emilgardis commented 1 year ago

this has been done in 986890022932bda84b35ee441d9e9e7ad2fd3cdb

dependabot[bot] commented 1 year ago

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.