search

twitchax / AspNetCore.Proxy

ASP.NET Core Proxies made easy.
MIT License
524 stars 83 forks source link

Fix for NullReferenceException when GetService<IHttpClientFactory>() fails #114

Closed amazur31 closed 1 month ago

amazur31 commented 8 months ago

Fix for this #98

It's 2:20 AM I was stuck on this error for too long... To whoever didn't fix it the first time - fuck you. To the creator of AspNetCore.Proxy - thank you.

twitchax commented 8 months ago

@amazur31, can you also add a test for this? Basically, want to make sure this doesn't get regressed.

codecov-commenter commented 8 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.97%. Comparing base (b3f70af) to head (e9393fd). Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/Core/Extensions/Http.cs 66.66% 0 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #114 +/- ## ========================================== - Coverage 99.85% 98.97% -0.88% ========================================== Files 12 12 Lines 686 686 Branches 84 86 +2 ========================================== - Hits 685 679 -6 Misses 1 1 - Partials 0 6 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.