search

twitchax / AspNetCore.Proxy

ASP.NET Core Proxies made easy.
MIT License
525 stars 83 forks source link

Fix for form reading bug. #60

Closed twitchax closed 4 years ago

codecov-commenter commented 4 years ago

Codecov Report

Merging #60 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #60   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          628       633    +5     
=========================================
+ Hits           628       633    +5
Impacted Files Coverage Δ
src/Core/Extensions/Http.cs 100.00% <100.00%> (ø)
src/Core/Helpers/Helpers.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 46fbd3f...6ea38e5. Read the comment docs.

twitchax commented 4 years ago

@PreferLinux, care to take a look?

twitchax commented 4 years ago

Thanks.

The only problem with the other solution is that there is no way to know, in the proxy logic, whether or not a controller "accidentally" consumes the form body by taking method parameters.