update packaging for .net 5

twitchax / AspNetCore.Proxy

ASP.NET Core Proxies made easy.

MIT License

524 stars 83 forks source link

update packaging for .net 5 #75

Closed baronfel closed 3 years ago

baronfel commented 3 years ago

This MR updates the packaging of this project (which is awesome, thanks by the way!) to support .net 5. There are no breaking API changes, it just means that we don't hit the old netstandard2.0 pathway which drags in Aspnetcore dependencies that aren't the framework reference.

twitchax commented 3 years ago

Hell yeah: I've been meaning to do this. Any ideas what the build failure is? Looks like there is just some issue finding the tests?

baronfel commented 3 years ago

yeah, that was it exactly. I forgot the formatting of TargetFramework vs TargetFrameworks

baronfel commented 3 years ago

Just a bit more work on making the netcoreapp3.1 sdk availble as well, then this should be good to go.

twitchax commented 3 years ago

@baronfel, I'll be honest: I've been dabbling in a lot of Rust lately and have not kept up on the .NET 5 news as much as I normally would have.

Do we still need to keep the netstandard2.0 targets around? Assuming yes for back compat?

baronfel commented 3 years ago

Yep! Generally for a library like this I recommend:

netstandard2.0 - for .net framework 48+ folks
netcoreapp3.1 - for LTS support
net5 - for latest awesomeness

baronfel commented 3 years ago

How's rust working for you? I'm mostly an F# guy myself and so knowing that it exists makes me more comfortable working on systems programming :)

baronfel commented 3 years ago

There we go, green at last :)

twitchax commented 3 years ago

Rust is fantastic: I highly recommend it. :)