search

twitchdev / extensions-hello-world

The Simplest Extension in the (Hello) World
Apache License 2.0
177 stars 85 forks source link

Remove jQuery dependency #17

Closed hiGarza closed 5 years ago

hiGarza commented 6 years ago

A developer should be able to move a Hello World project from local or online mode to a hosted test. If used as is and uploaded to Twitch our content security policy will reject the extension. I removed jQuery from the project in favor of vanilla JS.

Tenchumaru commented 5 years ago

Thanks, Humberto, but we chose to include jQuery locally instead of removing it altogether. This as two benefits.

  1. It's a smaller code change. This is a minor issue since it isn't a large amount of code to create the XMLHttpRequest as you have done.
  2. It gives us an opportunity to demonstrate how Twitch treats external libraries. People can discover this themselves the hard way as some have already done when trying to move this example extension to Hosted Test but, with this change, we can communicate a way to use external libraries.