twitchdev / issues

Issue tracker for third party developers.
Apache License 2.0
73 stars 6 forks source link

Get Emote Sets missing emotes for limited sets #445

Open willlllllio opened 3 years ago

willlllllio commented 3 years ago

Brief description

The "Get Emote Sets" endpoint misses lots of emotes for limited emote sets like pride emotes or holiday emotes that were unlockable by users by using bits.

How to reproduce

curl https://api.twitch.tv/helix/chat/emotes/set?emote_set_id=537206155 returns no emotes: { "data": []}

curl https://api.twitch.tv/helix/chat/emotes/set?emote_set_id=300206295 returns one out of 20 { "data": [ { "id": "300352343", "name": "PrideLionYay", "images": { "url_1x": "https://static-cdn.jtvnw.net/emoticons/v2/300352343/static/light/1.0", "url_2x": "https://static-cdn.jtvnw.net/emoticons/v2/300352343/static/light/2.0", "url_4x": "https://static-cdn.jtvnw.net/emoticons/v2/300352343/static/light/3.0" }, "emote_type": "limitedtime", "emote_set_id": "300206295", "owner_id": "139075904" } ]}

Expected behavior

return all emotes in those sets

"537206155":[{"id":302303601,"code":"PrideShrug"},{"id":302303599,"code":"PrideFloat"},{"id":302303596,"code":"PridePog"},{"id":302303594,"code":"PrideCute"},{"id":302303593,"code":"PrideLaugh"},{"id":302303590,"code":"PrideUwu"},{"id":302303587,"code":"PrideRhino"},{"id":302303585,"code":"PrideLGBTea"},{"id":302303582,"code":"PrideToucan"},{"id":302303581,"code":"PrideDragon"},{"id":302303580,"code":"PrideUnicorn"},{"id":302303579,"code":"PrideWave"},{"id":302303578,"code":"PridePenguin"},{"id":302303577,"code":"PrideFlower"},{"id":302303576,"code":"PrideLion"},{"id":302303574,"code":"PrideHeartR"},{"id":302303573,"code":"PrideHeartL"},{"id":302303570,"code":"PrideRise"},{"id":302303569,"code":"PrideStrong"},{"id":302303568,"code":"PrideLove"},{"id":302303567,"code":"PrideHeyyy"},{"id":302303566,"code":"PrideKoala"},{"id":302303565,"code":"PrideCrown"},{"id":302303564,"code":"PrideWorld"},{"id":302303563,"code":"PridePaint"}]

"300206295":[{"id":300352343,"code":"PrideLionYay"},{"id":300352352,"code":"PrideLionChomp"},{"id":300352355,"code":"PrideLionHey"},{"id":300352359,"code":"PrideBalloons"},{"id":300354391,"code":"PrideGive"},{"id":300354394,"code":"PrideTake"},{"id":300354405,"code":"PrideSaba"},{"id":300354435,"code":"PrideWingR"},{"id":300354442,"code":"PrideWingL"},{"id":300354448,"code":"PrideShine"},{"id":300354450,"code":"PrideParty"},{"id":300354457,"code":"PrideHi"},{"id":300354462,"code":"PrideGasp"},{"id":300354469,"code":"PrideCheers"},{"id":300354473,"code":"PridePan"},{"id":300354481,"code":"PrideAsexual"},{"id":300354485,"code":"PrideTrans"},{"id":300354494,"code":"PrideLesbian"},{"id":300354499,"code":"PrideBisexual"},{"id":300354465,"code":"PrideFlag"}]

Those are from the old kraken /kraken/users/{userid}/emotes endpoint that gives you all emotes a user has.

Screenshots

Additional context or questions

willlllllio commented 3 years ago

More broken emote set ids from the forum https://discuss.dev.twitch.tv/t/announcing-api-endpoints-for-twitch-emotes/32073/29: 472873131 477339272 488737509 537206155 564265402 592920959 610186276

Emilgardis commented 3 years ago

All of these are announced in irc tags.

Felanbird commented 2 years ago

All of these are announced in irc tags.

It should be noted that this is untrue, I personally have ALL the pride emotes but my userstate states that I only have PrideLionYay. see also: https://github.com/Chatterino/chatterino2/issues/3154#issuecomment-895529300 image

// the rest loaded from kraken/v5 image

// I was mistaken in the first part I had no idea the discussion about this was misinformed which likely caused it to be ignored, or I would have mentioned this a long time ago, but since the kraken shutdown is on Tuesday I assume we are screwed.

Emilgardis commented 2 years ago

All of these are announced in irc tags.

It should be noted that this is untrue, I personally have ALL the pride emotes but my userstate states that I only have PrideLionYay.

It was true at the time of my comment, and it still is true for me. My own USERSTATE has 472873131 477339272 488737509 537206155 564265402 592920959 610186276 537206155 300206295

Emotes I have that are not indexable in Helix are Hype (477339272 etc), KPOP (592920959), Haha (472873131), Pride (300206295, etc), Hyper (564265402), 2020 (610186276), RPG (300548756) and Luv (488737509) emotes (all of these are also in my own userstate)

Felanbird commented 2 years ago

It was true at the time of my comment, and it still is true for me.

My apologies, you are indeed correct that the last few emote sets numerically are the ones with the missing emotes that Helix cannot resolve, for some reason the comment you posted read to me as a disagreement, not an agreement with the original issue.

arrowgent commented 2 years ago

are there any plans to move these emote sets to helix api?

LeetHaxor commented 2 years ago

Is there any solution (temp or not) to this currently? Or are the emote sets just gone from chatterino until (tba)?

Felanbird commented 2 years ago

Is there any solution (temp or not) to this currently?

No API based solutions.

Or are the emote sets just gone from chatterino until (tba)?

Specific to Chatterino, you can make commands named after the event emotes you want, since commands are auto-completed with tab - but do not fire unless the command is at the start of the message, you can type asd123 hahat+tab and it can autocomplete to HahaThink and the text itself will be sent. image

LeetHaxor commented 2 years ago

Thanks, using that commands trick is perfect. 👍