twitchdev / issues

Issue tracker for third party developers.
Apache License 2.0
74 stars 6 forks source link

Continuing cancelled subscriptions triggers wrong events #469

Open Emilgardis opened 3 years ago

Emilgardis commented 3 years ago

Brief description Continuing a cancelled subscription with image on /subscriptions, triggers chat message and sends pubsub and chat with subplan: 1000, even if the subscription is for T3, i.e.

How to reproduce Cancel a subscription, go back to /subscriptions, click image. And authorize it. A chat event is sent in broadcasters channel, announcing subscription. with msg (I've removed PI, don't think it's relevant.)

@badge-info=subscriber/41;badges=moderator/1,subscriber/3030,bits/400000;color=#FF69B4;display-name=JustinTV;emotes=;flags=;id=msgid;login=justintv;mod=1;msg-id=resub;msg-param-cumulative-months=41;msg-param-months=0;msg-param-multimonth-duration=12;msg-param-multimonth-tenure=10;msg-param-should-share-streak=0;msg-param-sub-plan-name=Channel\sSubscription\s(twitchdev):\s$24.99\sSub;msg-param-sub-plan=1000;msg-param-was-gifted=false;room-id=1234;subscriber=1;system-msg=JustinTV\ssubscribed\sat\sTier\s1.\sThey've\ssubscribed\sfor\s41\smonths!;tmi-sent-ts=1628264202751;user-id=123;user-type=mod :tmi.twitch.tv USERNOTICE #twitchdev

and pubsub channel-subscribe-events-v1.1234:

{"benefit_end_month":9,"user_name":"justintv","display_name":"JustinTV","channel_name":"twitchdev","user_id":"123","channel_id":"1234","time":"2021-08-06T15:29:35.772442095Z","sub_message":{"message":"","emotes":null},"sub_plan":"1000","sub_plan_name":"Channel Subscription (twitchdev): $24.99 Sub","months":0,"cumulative_months":41,"context":"resub","is_gift":false,"multi_month_duration":0}"}}\r\n"))}

Expected behavior No Chat event, specialized pubsub message (possibly context resub_continued) and correct subplan.

As can be seen, the sub_plan is 1000, but sub_plan_name is 24.99 pricing.

Screenshots

Additional context or questions It's possible to retrigger this x amount of times, have been able to do it myself many times now.

Emilgardis commented 3 years ago

My bad, filed this under eventsub, should be pubsub and chat, but I'm pretty sure this fails on eventsub as well.